Skip to content

fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine#9274

Closed
legobeat wants to merge 10 commits intomainfrom
deps-eth-json-rpc-filters
Closed

fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine#9274
legobeat wants to merge 10 commits intomainfrom
deps-eth-json-rpc-filters

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Apr 17, 2024 •
edited
Loading

Description

The runtime dependencies eth-json-rpc-filters and json-rpc-engine are both deprecated. This replaces them with their successors @metamask/eth-json-rpc-filters and @metamask/json-rpc-engine, respectively.

Related issues

Manual testing steps

n/a

Screenshots/Recordings

Before

n/a

After

n/a

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

This comment was marked as off-topic.

Sign in to view
@legobeat legobeat changed the title Deps eth json rpc filters fix(deps): upgrade eth-json-rpc-filters, eth-json-rpc-engine Apr 17, 2024
@socket-security
Copy link

socket-security bot commented Apr 17, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@legobeat legobeat added dependencies Pull requests that update a dependency file team-application-security Application security team labels Apr 17, 2024
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters branch from b3da306 to 27ade1b Compare April 17, 2024 04:30
@legobeat
Copy link
Contributor Author

legobeat commented Apr 17, 2024 

@SocketSecurity ignore npm/@metamask/[email protected]

@legobeat legobeat mentioned this pull request Apr 17, 2024
Closed
7 tasks
@socket-security
Copy link

socket-security bot commented Apr 17, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 24.6 kB lgbot

🚮 Removed packages: npm/[email protected]

View full report↗︎

@legobeat legobeat force-pushed the deps-eth-json-rpc-filters branch 4 times, most recently from 53c8a35 to 69be175 Compare April 18, 2024 21:09
@github-actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters branch 3 times, most recently from a443778 to 9b7463f Compare April 18, 2024 22:03
@github-actions

This comment was marked as outdated.

Sign in to view
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters branch from 6cec69d to 45cfe8d Compare April 19, 2024 03:01
@github-actions

This comment was marked as outdated.

Sign in to view
@legobeat
Copy link
Contributor Author

legobeat commented May 20, 2024

@legobeat Still working on this? It looks like based on the CI failures that we might need to bump transaction-controller?

Recently, no. And yes, looks like that is related. Would you know which version of @metamask/transaction-controller would unlock this?

@github-actions

This comment was marked as outdated.

Sign in to view
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 47.00%. Comparing base (678c2f6) to head (9c26f2c).
Report is 12 commits behind head on main.

Files Patch % Lines
app/core/WalletConnect/WalletConnectV2.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9274      +/-   ##
==========================================
+ Coverage   46.66%   47.00%   +0.34%     
==========================================
  Files        1343     1353      +10     
  Lines       32805    33120     +315     
  Branches     3527     3557      +30     
==========================================
+ Hits        15307    15569     +262     
- Misses      16554    16602      +48     
- Partials      944      949       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat mentioned this pull request Jun 11, 2024
Closed
7 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4a914af
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bcc52743-ae03-4059-a97b-abd804453cc0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat
Copy link
Contributor Author

legobeat commented Jun 11, 2024 •
edited
Loading

@legobeat Still working on this? It looks like based on the CI failures that we might need to bump transaction-controller?

Recently, no. And yes, looks like that is related. Would you know which version of @metamask/transaction-controller would unlock this?

Looking at it now, the mismatching types due to mismatching versions look like they should be resolved by upgrading @metamask/transaction-controller from ^13 to ^15, which implies a bump of @metamask/network-controller to ^15 and its @metamask/json-rpc-middleware from ^11 to ^12.

@legobeat
Copy link
Contributor Author

legobeat commented Jun 11, 2024

The failing Check for js or jsx file being added rule seems to FP on changed files and interpreting them as added.

@legobeat

This comment was marked as resolved.

Sign in to view
This was referenced Jun 11, 2024
Closed
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 11, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

3 similar comments
@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 11, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 11, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot
Copy link
Collaborator

metamaskbot commented Jun 11, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8920824
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53b4eec6-1e48-4c84-8fd7-aaa5dcf16513

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat mentioned this pull request Sep 20, 2024
Closed
7 tasks
@legobeat legobeat mentioned this pull request Oct 25, 2024
Merged
7 tasks
@legobeat
Copy link
Contributor Author

legobeat commented Oct 25, 2024

The eth-json-rpc-filters upgrade has been broken out into:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@FrederikBolding FrederikBolding Awaiting requested review from FrederikBolding

Assignees

@NicolasMassart NicolasMassart

Labels

dependencies Pull requests that update a dependency file DO-NOT-MERGE Pull requests that should not be merged stale Issues that have not had activity in the last 90 days team-application-security Application security team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legobeat @metamaskbot @mcmire @codecov-commenter @NicolasMassart